linux-kernel - Re: [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4004f37e-66f8-4ba3-bfa4-41235e979043@gmail.com>
Date:   Tue, 21 Nov 2023 22:39:48 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Gary Rookard <garyrookard@...tmail.org>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables
 patch series

On 11/21/23 19:14, Gary Rookard wrote:
> Hi,
> 
> This patch series renames 5 different variables from
> Pascal/CamelCase to snake case.
> 
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
> Driver/module rtl8291e compiles.
> 
> Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate
> Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate
> Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps
> Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine
> Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
> 
> Regards,
> Gary
> 

Hi Gary,

this patch series needs to be a V2 with change history.

The next patch series you are going to send is V3.

The cover letter of your patch series seems to be hand made. You can use 
git to do this.

I am using this command to do this:
git format-patch -o ~/Documents/kernel/patches/ --cover-letter -n 
--thread=shallow --to="Greg Kroah-Hartman 
<gregkh@...uxfoundation.org>,linux-staging@...ts.linux.dev,linux-kernel@...r.kernel.org" 
7b88c62d3cc5c3fb670b5448c7381c7c099b3518^..HEAD

There are now 31 patches pending for this driver. May be it is a good 
idea to wait until those are accepted or rejected. May be this is 
happening on Thursday morning. Or you apply the patches before you put 
yours on top:

https://lore.kernel.org/linux-staging/c464f4a8-753b-417c-97bb-7aa29ab5bf59@gmail.com/T/#t

https://lore.kernel.org/linux-staging/cover.1700296319.git.philipp.g.hortmann@gmail.com/T/#t

https://lore.kernel.org/linux-staging/d911d509-8677-444c-ad7f-92dd141e8e1e@suswa.mountain/T/#t

In case of question feel free to write to me.

Bye Philipp