linux-kernel - Re: [PATCH] ARM: multi_v7_defconfig: Add SCMI reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16304f9a-fbbb-497f-917a-c2e2b8d67d9e@foss.st.com>
Date:   Tue, 21 Nov 2023 10:19:08 +0100
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     Etienne Carriere <etienne.carriere@...s.st.com>,
        <linux-kernel@...r.kernel.org>
CC:     Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Kevin Hilman <khilman@...libre.com>, <soc@...nel.org>,
        <arm@...nel.org>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Add SCMI reset support

Hi Etienne

On 11/3/23 09:54, Etienne Carriere wrote:
> SCMI reset controllers are used in the ARMv7 STMicroelectronics stm32mp
> boards:
> - for STM32MP13: stm32mp135f-dk
> - for STM32MP15 boards with SCMI variant, introduced by commit 5b7e58313a77
>    ("ARM: dts: stm32: Add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)")
>    * stm32mp157c-ev1-scmi
>    * stm32mp157c-ed1-scmi
>    * stm32mp157c-dk2-scmi
>    * stm32mp157a-dk1-scmi
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@...s.st.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 23fc49f23d25..01b3797f9317 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -1189,6 +1189,7 @@ CONFIG_PWM_TEGRA=y
>   CONFIG_PWM_VT8500=y
>   CONFIG_KEYSTONE_IRQ=y
>   CONFIG_RESET_MCHP_SPARX5=y
> +CONFIG_RESET_SCMI=y
>   CONFIG_PHY_SUN4I_USB=y
>   CONFIG_PHY_SUN9I_USB=y
>   CONFIG_PHY_BRCM_USB=m

Just one question before to apply this patch. CONFIG_RESET_SCMI is set 
by the following dependency in drivers/reset/Kconfig:

RESET_CONTROLLER [=y] && (ARM_SCMI_PROTOCOL [=y] || COMPILE_TEST [=n])

CONFIG_ARM_SCMI is already set in multi_v7_defconfig.
CONFIG_RESET_CONTROLLER seems to be set in each platform Kconfig.

So not sure we need to force CONFIG_RESET_SCMI in the multi_v7_defconfig.

Regards
Alex