[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZVyz6ctZVcDVM0N4@yury-ThinkPad>
Date: Tue, 21 Nov 2023 05:43:05 -0800
From: Yury Norov <yury.norov@...il.com>
To: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc: linux-kernel@...r.kernel.org,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org,
Jan Kara <jack@...e.cz>,
Mirsad Todorovac <mirsad.todorovac@....unizg.hr>,
Matthew Wilcox <willy@...radead.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
Alexey Klimov <klimov.linux@...il.com>
Subject: Re: [PATCH 34/34] sh: rework ilsel_enable()
On Sat, Nov 18, 2023 at 05:15:57PM +0100, John Paul Adrian Glaubitz wrote:
> Hello Yury!
>
> On Sat, 2023-11-18 at 07:51 -0800, Yury Norov wrote:
> > Fix opencoded find_and_set_bit(), which also suppresses potential
> > KCSAN warning.
> >
> > Signed-off-by: Yury Norov <yury.norov@...il.com>
> > ---
> > arch/sh/boards/mach-x3proto/ilsel.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/sh/boards/mach-x3proto/ilsel.c b/arch/sh/boards/mach-x3proto/ilsel.c
> > index f0d5eb41521a..7fadc479a80b 100644
> > --- a/arch/sh/boards/mach-x3proto/ilsel.c
> > +++ b/arch/sh/boards/mach-x3proto/ilsel.c
> > @@ -99,8 +99,8 @@ int ilsel_enable(ilsel_source_t set)
> > }
> >
> > do {
> > - bit = find_first_zero_bit(&ilsel_level_map, ILSEL_LEVELS);
> > - } while (test_and_set_bit(bit, &ilsel_level_map));
> > + bit = find_and_set_bit(&ilsel_level_map, ILSEL_LEVELS);
> > + } while (bit >= ILSEL_LEVELS);
> >
> > __ilsel_enable(set, bit);
> >
>
> The subject should mention the subsystem, i.e. "sh: mach-x3proto:".
OK, will do in v2
Powered by blists - more mailing lists