linux-kernel - Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbb60eed-a835-4ee7-a43d-e871c16713e1@o2.pl>
Date:   Wed, 22 Nov 2023 17:58:07 +0100
From:   Mateusz Jończyk <mat.jonczyk@...pl>
To:     Mario Limonciello <mario.limonciello@....com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, tobrohl@...il.com, aalsing@...il.com,
        Dhaval.Giani@....com, xmb8dsv4@...il.com, x86@...nel.org,
        dhaval.giani@...il.com
Subject: Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers

W dniu 20.11.2023 o 15:15, Mario Limonciello pisze:
> A number of users have reported their system will have a failure reading
> the RTC around s2idle entry or exit.
>
> This failure manifests as UIP clear taking longer than 10ms.
>
> By a debugging patch provided by Mateusz Jończyk it is shown that this
> has taken upwards of 300ms in some cases.
>
> This series adjusts the UIP timeout to be configurable by the caller and
> changes some callers which aren't called in an interrupt context to allow
> longer timeouts.
>
> Mario Limonciello (4):
>   rtc: mc146818-lib: Adjust failure return code for mc146818_get_time()
>   rtc: Adjust failure return code for cmos_set_alarm()
>   rtc: Add support for configuring the UIP timeout for RTC reads
>   rtc: Extend timeout for waiting for UIP to clear to 1s

Series tested on top of Linux 6.1.63, 6.6.2 and 6.7-rc2
(on a laptop that is not affected by the problems).
No problems found, can be submitted to stable.

Tested-by: Mateusz Jończyk <mat.jonczyk@...pl>

Patches 1 and 2:

Reviewed-by: Mateusz Jończyk <mat.jonczyk@...pl>
Acked-by: Mateusz Jończyk <mat.jonczyk@...pl>

Greetings,

Mateusz