linux-kernel - Re: [PATCH] um: Use swap() instead of open coding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fa7ec68a0302667f1b73682e4db96f6ba618397.camel@sipsolutions.net>
Date:   Wed, 22 Nov 2023 08:25:54 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, richard@....at
Cc:     anton.ivanov@...bridgegreys.com, linux-um@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] um: Use swap() instead of open coding it

On Wed, 2023-11-22 at 11:25 +0800, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
> 
> ./arch/um/os-Linux/sigio.c:81:28-29: WARNING opportunity for swap().
> 

Hm. There's already a use of swap() here in this file, but I actually
think we should revert that? This is basically userspace code, not
kernel code, so I don't think it should include linux headers, even if
those happen to be "standalone enough" right now to work.

johannes