linux-kernel - Re: [PATCH v5] zswap: memcontrol: implement zswap writeback disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=NpKqjApRKk2Qp9Hp63xSjRwD-DEu9yX4BvbMd86x2b1g@mail.gmail.com>
Date:   Tue, 21 Nov 2023 17:19:19 -0800
From:   Nhat Pham <nphamcs@...il.com>
To:     Chris Li <chrisl@...nel.org>
Cc:     Yosry Ahmed <yosryahmed@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>, tj@...nel.org,
        lizefan.x@...edance.com, Johannes Weiner <hannes@...xchg.org>,
        Domenico Cerasuolo <cerasuolodomenico@...il.com>,
        Seth Jennings <sjenning@...hat.com>,
        Dan Streetman <ddstreet@...e.org>,
        Vitaly Wool <vitaly.wool@...sulko.com>,
        Michal Hocko <mhocko@...nel.org>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Shakeel Butt <shakeelb@...gle.com>,
        Muchun Song <muchun.song@...ux.dev>,
        Hugh Dickins <hughd@...gle.com>, corbet@....net,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        senozhatsky@...omium.org, rppt@...nel.org,
        linux-mm <linux-mm@...ck.org>, kernel-team@...a.com,
        LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
        david@...t.cz, Minchan Kim <minchan@...gle.com>,
        Kairui Song <kasong@...cent.com>,
        Zhongkun He <hezhongkun.hzk@...edance.com>
Subject: Re: [PATCH v5] zswap: memcontrol: implement zswap writeback disabling

On Tue, Nov 21, 2023 at 11:09 AM Chris Li <chrisl@...nel.org> wrote:
>
> On Tue, Nov 21, 2023 at 10:13 AM Nhat Pham <nphamcs@...il.com> wrote:
> >
> > Hi Chris!
> >
> > Thanks for the patch. Would you mind if I spend some time staring
> > at the suggestion again and testing it some more?
>
> Of course, by all means. That is just the minimal version to be
> functional compatible with your zswap.writeback.
>
> I might consider a follow up patch to add "no_zswap" and "none" to
> convert the SSD only swapfile, which can't be expressed by
> zswap.writeback.
> That should cover all 4 combinations of zswap and swap files without
> creating a custom swap tiers list.
>
> "all": zswap + swapfile
> "zswap": zswap only
> "no_zswap": swapfile only.
> "none": no swap.
>
> All keyword names are open to suggestions.

SGTM! There might be some functionality duplication between
memory.swap.tiers = no_zswap and memory.zswap.max = 0, but
otherwise this seems reasonable to me.

no_zswap sounds a bit awkward, but I can't come up with a better
name.

>
> >
> > If everything is good, I'll squash this patch with the original version,
> > (keeping you as a co-developer of the final patch of course), and
> > update the documentation before re-sending everything as v6.
>
> Great!
>
> >
> > Anyway, have a nice Thanksgiving break everyone! Thanks for
> > taking the time to review my patch and discuss the API with me!
>
> My pleasure to discuss the swap with you. We should do the online
> "swap meet" and invite other developers who are interested in the swap
> area as well.

I look forward to this meeting! I'd love to discuss more about (z)swap
development (and more generally, multi-tier memory management).

Generic page promoter/demoter that takes into account workload
(cgroup), access recency (LRU + generations)/frequency, and tier
characteristics (latency, bandwidth, etc.) will be awesome to explore!

>
> Chris