linux-kernel - Re: [PATCH] MAINTAINERS: add section MIPS BAIKAL-T1 SOC DRIVERS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKXUXMwGgtJVWmrFX0chpgNC++Ok54t-qXxware+aEDiyZFszw@mail.gmail.com>
Date:   Wed, 22 Nov 2023 14:49:54 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
Subject: Re: [PATCH] MAINTAINERS: add section MIPS BAIKAL-T1 SOC DRIVERS

On Wed, Nov 22, 2023 at 2:32 PM Serge Semin
<Sergey.Semin@...kalelectronics.ru> wrote:
>
> Hi Lukas
>
> On Wed, Nov 22, 2023 at 06:41:42AM +0100, Lukas Bulwahn wrote:
> > In recent years, a number of drivers for the MIPS Baikal-T1 SoC have been
> > added to the kernel tree, but there is no dedicated MAINTAINERS section for
> > this SoC.
> >
> > As all of the code has been contributed by Serge Semin, let us assume he is
> > still the active maintainer for this code rather than marking it orphan.
> >
> > Add a new section MIPS BAIKAL-T1 SOC DRIVERS in MAINTAINERS.
>
> Thanks for submitting this patch. I was going to send a similar change
> in the framework of the arch-series which is hanging up in my local
> repo and alas is still under construction. I know I shouldn't have
> been waiting (I'm sorry about that), but I didn't expect the entire
> work would have taken so much time. On a way to finishing it up I had
> to switch my efforts to the EDAC and network drivers and got sucked by
> the amount of work there. But I will definitely submit the Baikal-T1
> SoC arch patchset when my work on another area is finally over.
>
> Here are several comments about this patch. (Please see my last
> comment should you be ok with accepting the patches with already fixed
> notes.)
>
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> > ---
> >  MAINTAINERS | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9613c9c3cc97..820f1ab1ee80 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14474,6 +14474,19 @@ F:   arch/mips/
> >  F:   drivers/platform/mips/
> >  F:   include/dt-bindings/mips/
> >
> > +MIPS BAIKAL-T1 SOC DRIVERS
>
> > +M:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
>
> It's better to change the email to
> +M:     Serge Semin <fancer.lancer@...il.com>
> I quicker respond from my private inbox, than from the corporate one.
> This will also be useful should the corporate email eventually change.
>
> > +S:   Maintained
>
> +F:     Documentation/devicetree/bindings/bus/baikal,bt1-*.yaml
> +F:     Documentation/devicetree/bindings/clock/baikal,bt1-*.yaml
>
> > +F:   Documentation/hwmon/bt1-pvt.rst
>
> I'd prefer this and these -+ being in a separate entry (see the
> attached patches), because | the respective device IP-cores have been
> re-used in another SoC. So | eventually the entries will be updated to
> reflect that.              +---------------------------------+
>                                                              |
> > +F:   drivers/ata/ahci_dwc.c                               |
>                                                              |
> I believe this is already listed in the MAINTAINERS file.    |
>                                                              |
> > +F:   drivers/bus/bt1-*.c                                  |
> > +F:   drivers/clk/baikal-t1/                               |
> > +F:   drivers/hwmon/bt1-pvt.[ch] <-------------------------+
> > +F:   drivers/memory/bt1-l2-ctl.c                          |
> > +F:   drivers/mtd/maps/physmap-bt1-rom.[ch]                |
> > +F:   drivers/pci/controller/dwc/pcie-bt1.c <--------------+
>
> > +F:   drivers/spi/spi-dw-bt1.c
>
> This is already marked as maintained by me in the framework of the
> generic DW APB SSI driver (See the "SYNOPSYS DESIGNWARE APB SSI
> DRIVER" entry in the MAINTAINERS file).
>
> Anyway in order to save your time from editing this patch. I've
> prepared a series which takes into account all the comments above. If
> you are ok with it, I can submit it for review. What do you think?
>

Sure, go ahead and submit your series. I just wanted to have all files
in ./drivers/bus/ have a proper maintainer and then got to look at the
BAIKAL T1 files.

Lukas

> -Serge(y)
>
> > +
> >  MIPS BOSTON DEVELOPMENT BOARD
> >  M:   Paul Burton <paulburton@...nel.org>
> >  L:   linux-mips@...r.kernel.org
> > --
> > 2.17.1
> >
> >