linux-kernel - Re: [PATCH] rhashtable: Better error message on allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231123235840.76nk3grth2sqmonc@moria.home.lan>
Date:   Thu, 23 Nov 2023 18:58:40 -0500
From:   Kent Overstreet <kent.overstreet@...ux.dev>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     linux-kernel@...r.kernel.org, Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH] rhashtable: Better error message on allocation failure

On Thu, Nov 23, 2023 at 04:32:47PM +0800, Herbert Xu wrote:
> On Wed, Nov 22, 2023 at 06:32:16PM -0500, Kent Overstreet wrote:
> > Memory allocation failures print backtraces by default, but when we're
> > running out of a rhashtable worker the backtrace is useless - it doesn't
> > tell us which hashtable the allocation failure was for.
> > 
> > This adds a dedicated warning that prints out functions from the
> > rhashtable params, which will be a bit more useful.
> > 
> > Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
> > Cc: Thomas Graf <tgraf@...g.ch>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > ---
> >  lib/rhashtable.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> However, you'll need to repost this via netdev@...r.kernel.org for
> it to be merged.

Thanks!