linux-kernel - Re: [PATCH v3 3/3] regulator: mt6358: Add output voltage fine tuning to variable LDOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5E4TXrPmhb++r3vMGA4WoPc=covi7_=zgLLcOhGt9UBgg@mail.gmail.com>
Date:   Thu, 23 Nov 2023 14:25:01 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Bret Joseph <bretjoseph@...il.com>
Cc:     angelogioacchino.delregno@...labora.com, broonie@...nel.org,
        matthias.bgg@...il.com, linux-kernel@...r.kernel.org,
        zhiyong.tao@...iatek.com, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 3/3] regulator: mt6358: Add output voltage fine tuning
 to variable LDOs

Hi Bret,

On Thu, Nov 16, 2023 at 12:52 AM Bret Joseph <bretjoseph@...il.com> wrote:
>
> In mt6358-regulator.c
>
> static const struct regulator_ops mt6358_volt_table_ops = {
>     .list_voltage = regulator_list_voltage_pickable_linear_range,
>     .map_voltage = regulator_map_voltage_pickable_linear_range,
>     .set_voltage_sel = regulator_set_voltage_sel_pickable_regmap,
>     .get_voltage_sel = mt6358_get_buck_voltage_sel /*regulator_get_voltage_sel_pickable_regmap*/,
>     .set_voltage_time_sel = regulator_set_voltage_time_sel,
>     .enable = regulator_enable_regmap,
>     .disable = regulator_disable_regmap,
>     .is_enabled = regulator_is_enabled_regmap,
>     .get_status = mt6358_get_status,
> };
>
> the function [regulator_get_voltage_sel_pickable_regmap] causes a -EINVAL‬ when registering
>
> vsim1 vusb vcamd vefuse vmch vcama1 vemc vmc vldo28 vsim2
>
> using [mt6358_get_buck_voltage_sel] results in a successful probe

Sure it will probe, but any values you read back will be bogus.

Can you provide a dump of /sys/kernel/debug/regulator/regulator_summary
and `grep ^1e..: /sys/kernel/debug/regmap/1000d000.pwrap/registers`,
and also any relevant logs?

ChenYu