linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: frequency: add admfm2000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <676c55c7-1477-4c59-a1fe-2b50e37018a0@linaro.org>
Date:   Thu, 23 Nov 2023 08:20:25 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Paller, Kim Seer" <KimSeer.Paller@...log.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: frequency: add admfm2000

On 23/11/2023 07:13, Paller, Kim Seer wrote:
>>> ---
>>> V2 -> V3: Adjusted indentation to resolve wrong indentation warning.
>>>           Changed node name to converter. Updated the descriptions to clarify
>>>           the properties.
>>
>>
>>> +title: ADMFM2000 Dual Microwave Down Converter
>>> +
>>> +maintainers:
>>> +  - Kim Seer Paller <kimseer.paller@...log.com>
>>> +
>>> +description:
>>> +  Dual microwave down converter module with input RF and LO frequency
>> ranges
>>> +  from 0.5 to 32 GHz and an output IF frequency range from 0.1 to 8 GHz.
>>> +  It consists of a LNA, mixer, IF filter, DSA, and IF amplifier for each down
>>> +  conversion path.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - adi,admfm2000
>>> +
>>> +  switch1-gpios:
>>> +    items:
>>> +      - description:
>>> +          Setting B15 GPIO to high and B16 GPIO to low will result in channel 1
>>> +          being in Direct IF mode.
>>> +      - description:
>>> +          Setting B15 GPIO to low and B16 GPIO to high will result in channel 1
>>> +          being in Mixer mode.
>>
>> This still does not tell which one is B15 and which is B16. I am asking
>> this for third time.
>>
>> items:
>>   - description: B15 GPIO, when high (and B16 low) channel 1 is in
>> Direct IF mode
> 
> I understand now, thank you. I was also wondering if this applies to the 
> attenuation-gpios, or if I should keep it as is?

Yes, something like this applies to all your properties with multiple
entries. You need to define the order.

Best regards,
Krzysztof