linux-kernel - Re: [PATCH net-next 5/7] net/smc: compatible with 128-bits extend GID of virtual ISM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24ea5034-78ef-c173-3739-fb05418f8d11@linux.alibaba.com>
Date:   Thu, 23 Nov 2023 21:16:39 +0800
From:   Wen Gu <guwen@...ux.alibaba.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     wintera@...ux.ibm.com, wenjia@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, kgraul@...ux.ibm.com,
        jaka@...ux.ibm.com, borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com,
        raspl@...ux.ibm.com, schnelle@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 5/7] net/smc: compatible with 128-bits extend GID
 of virtual ISM device



On 2023/11/21 03:17, Jakub Kicinski wrote:
> On Sun, 19 Nov 2023 21:57:55 +0800 Wen Gu wrote:
>> According to virtual ISM support feature defined by SMCv2.1, GIDs of
>> virtual ISM device are UUIDs defined by RFC4122, which are 128-bits
>> long. So some adaptation work is required. And note that the GIDs of
>> existing platform firmware ISM devices still remain 64-bits long.
> 
> sparse (C=1 build) complains:
> 
> net/smc/smc_clc.c:944:73: warning: incorrect type in argument 1 (different base types)
> net/smc/smc_clc.c:944:73:    expected unsigned short [usertype] chid
> net/smc/smc_clc.c:944:73:    got restricted __be16 [usertype] chid

It will be fixed in the next version. Thank you very much!

Thanks,
Wen Gu