linux-kernel - Re: [PATCH 2/2] interconnect: qcom: Add SM6115 interconnect provider driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bb681c7-8a93-4010-b473-887d68c6a5d2@linaro.org>
Date:   Sat, 25 Nov 2023 23:16:39 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH 2/2] interconnect: qcom: Add SM6115 interconnect provider
 driver

On 25.11.2023 16:59, Konrad Dybcio wrote:
> Add a driver for managing NoC providers on SM6115.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
The following diff is missing:


----o<----

diff --git a/drivers/interconnect/qcom/sm6115.c b/drivers/interconnect/qcom/sm6115.c
index d7600dfe56c0..5b21566d64a5 100644
--- a/drivers/interconnect/qcom/sm6115.c
+++ b/drivers/interconnect/qcom/sm6115.c
@@ -609,8 +609,8 @@ static struct qcom_icc_node xm_usb3_0 = {
 static struct qcom_icc_node ebi = {
        .name = "ebi",
        .id = SM6115_SLAVE_EBI_CH0,
-       .channels = 1,
-       .buswidth = 8,
+       .channels = 2,
+       .buswidth = 4,
        .mas_rpm_id = -1,
        .slv_rpm_id = 0,
 };

----o<----

Georgi, if everything else is fine, could you please squash it while
applying? Otherwise I'll just amend it in v2.

Konrad