[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8366b046-068e-41df-9dd6-9aa4beefc6ca@linaro.org>
Date: Mon, 27 Nov 2023 09:17:39 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Georgi Djakov <djakov@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM6115 NoC
On 25/11/2023 16:59, Konrad Dybcio wrote:
> Add bindings for Qualcomm SM6115 Network-On-Chip interconnect.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
> .../bindings/interconnect/qcom,sm6115.yaml | 128 +++++++++++++++++++++
> include/dt-bindings/interconnect/qcom,sm6115.h | 111 ++++++++++++++++++
> 2 files changed, 239 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
> new file mode 100644
> index 000000000000..8908946eb391
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
> @@ -0,0 +1,128 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,sm6115.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SM6115 Network-On-Chip interconnect
> +
> +maintainers:
> + - Konrad Dybcio <konradybcio@...nel.org>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The Qualcomm SM6115 interconnect providers support adjusting the
> + bandwidth requirements between the various NoC fabrics.
> +
> +properties:
> + reg:
> + maxItems: 1
> +
> + compatible:
compatible is the first in properties (move it before reg).
> + enum:
> + - qcom,sm6115-bimc
> + - qcom,sm6115-cnoc
> + - qcom,sm6115-snoc
> +
Add clocks: with min/maxItems here. Same with clock-names.
> +# Child node's properties
> +patternProperties:
> + '^interconnect-[a-z0-9]+$':
> + type: object
> + description:
> + The interconnect providers do not have a separate QoS register space,
> + but share parent's space.
> +
> + allOf:
Drop allOf, just $ref.
> + - $ref: qcom,rpm-common.yaml#
> +
> + properties:
> + compatible:
> + enum:
> + - qcom,sm6115-clk-virt
> + - qcom,sm6115-mmrt-virt
> + - qcom,sm6115-mmnrt-virt
> +
> + required:
> + - compatible
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
Put it after allOf: block.
> +
> +allOf:
> + - $ref: qcom,rpm-common.yaml#
> + - if:
> + properties:
> + compatible:
> + const: qcom,sm6115-cnoc
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: USB-NoC AXI clock
> +
> + clock-names:
> + items:
> + - const: usb_axi
> +
> + - if:
> + properties:
> + compatible:
> + const: qcom,sm6115-snoc
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: CPU-NoC AXI clock.
> + - description: UFS-NoC AXI clock.
> + - description: USB-NoC AXI clock.
> + - description: IPA clock.
> +
> + clock-names:
> + items:
> + - const: cpu_axi
> + - const: ufs_axi
> + - const: usb_axi
> + - const: ipa
Add if: for remaining variant disallowing clocks and clock-names.
(clocks: false)
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
Is it used?
> +
> + snoc: interconnect@...0000 {
> + compatible = "qcom,sm6115-snoc";
> + reg = <0x01880000 0x60200>;
> + #interconnect-cells = <1>;
Missing clocks.
> +
> + qup_virt: interconnect-qup {
> + compatible = "qcom,sm6115-qup-virt";
> + #interconnect-cells = <1>;
> + };
> +
> + mmnrt_virt: interconnect-mmnrt {
> + compatible = "qcom,sm6115-mmnrt-virt";
> + #interconnect-cells = <1>;
> + };
> +
> + mmrt_virt: interconnect-mmrt {
> + compatible = "qcom,sm6115-mmrt-virt";
> + #interconnect-cells = <1>;
> + };
> + };
> +
> + cnoc: interconnect@...0000 {
> + compatible = "qcom,sm6115-cnoc";
> + reg = <0x01900000 0x8200>;
> + #interconnect-cells = <1>;
> + };
> +
> + bimc: interconnect@...0000 {
> + compatible = "qcom,sm6115-bimc";
> + reg = <0x04480000 0x80000>;
> + #interconnect-cells = <1>;
> + };
Drop this node, duplicates cnoc.
> diff --git a/include/dt-bindings/interconnect/qcom,sm6115.h b/include/dt-bindings/interconnect/qcom,sm6115.h
> new file mode 100644
> index 000000000000..21090e585f05
Best regards,
Krzysztof
Powered by blists - more mailing lists