linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add dynamic-power-coefficient to rk3399 GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2023 10:42:02 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Lukasz Luba <lukasz.luba@....com>
Cc:     lukasz.luba@....com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        daniel.lezcano@...aro.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add dynamic-power-coefficient to rk3399 GPU

Hi Lukasz,

Am Montag, 27. November 2023, 09:15:11 CET schrieb Lukasz Luba:
> Add dynamic-power-coefficient to the GPU node. That will create Energy
> Model for the GPU based on the coefficient and OPP table information.
> It will enable mechanism such as DTMP or IPA to work with the GPU DVFS.
> In similar way the Energy Model for CPUs in rk3399 is created, so both
> are aligned in power scale. The maximum power used from this coefficient
> is 1.5W at 600MHz.

2640 is a pretty arbitary value, so it would be really helpful to describe
in the commit message, how you arrived with that specific value.


Thanks
Heiko


> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 9da0b6d77c8d..87cfdf570b19 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -2113,6 +2113,7 @@ gpu: gpu@...a0000 {
>  		interrupt-names = "job", "mmu", "gpu";
>  		clocks = <&cru ACLK_GPU>;
>  		#cooling-cells = <2>;
> +		dynamic-power-coefficient = <2640>;
>  		power-domains = <&power RK3399_PD_GPU>;
>  		status = "disabled";
>  	};
>