linux-kernel - RE: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR13MB273808C3B81BABBAADACC6B6FDBCA@BN8PR13MB2738.namprd13.prod.outlook.com>
Date:   Tue, 28 Nov 2023 17:54:57 +0000
From:   "Bird, Tim" <Tim.Bird@...y.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
CC:     Shuah Khan <shuah@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        "kernelci@...ts.linux.dev" <kernelci@...ts.linux.dev>,
        David Gow <davidgow@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "kernel@...labora.com" <kernel@...labora.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Doug Anderson <dianders@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for
 google,spherion

> -----Original Message-----
> From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> On Tue, Nov 28, 2023 at 12:10:46AM +0000, Bird, Tim wrote:
> > > -----Original Message-----
> > > From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > > Add a sample board file describing the file's format and with the list
> > > of devices expected to be probed on the google,spherion machine as an
> > > example.
> > >
> > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >  .../testing/selftests/devices/boards/google,spherion | 12 ++++++++++++
> >
> > Overall, while trying to maintain a comprehensive set of board definitions
> > seems hard, I think having a few as examples is useful.
> >
> > I'm not a big fan of naming these with a comma in the name.  Is there a reason
> > you are not using dash or underscore?
> 
> I'm using the name that we get from the DT compatible, so the right file can be
> automatically selected by the test.
> 
> >
> > Do you anticipate a convention of  <producer> <board-or-product-name> tuples for
> > the filename?
> 
> I'd just stick to the DT compatible as it's the simplest option and should work
> just the same, assuming I understood correctly what you mean.

OK - I see that was mentioned in the original submission.  I should
have read more closely.

It makes sense.  Maybe it's worth mentioning in the commit message that the
filename is the compatible string from the DT for this board?

This convention, IMHO, should be documented somewhere.

Thanks.
 -- Tim