linux-kernel - Re: [PATCH 2/9] net: mdio: ipq4019: Enable the clocks for ipq5332 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16265061-3850-483b-9040-3540a6a173d8@quicinc.com>
Date:   Tue, 28 Nov 2023 15:07:19 +0800
From:   Jie Luo <quic_luoj@...cinc.com>
To:     Simon Horman <horms@...nel.org>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <andrew@...n.ch>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <robert.marko@...tura.hr>,
        <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH 2/9] net: mdio: ipq4019: Enable the clocks for ipq5332
 platform



On 11/27/2023 5:37 PM, Simon Horman wrote:
> On Wed, Nov 15, 2023 at 11:25:08AM +0800, Luo Jie wrote:
>> For the platform ipq5332, the related GCC clocks need to be enabled
>> to make the GPIO reset of the MDIO slave devices taking effect.
>>
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
>> ---
>>   drivers/net/mdio/mdio-ipq4019.c | 67 +++++++++++++++++++++++++++++----
>>   1 file changed, 60 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c
>> index 9d444f5f7efb..a77982a1a1e1 100644
>> --- a/drivers/net/mdio/mdio-ipq4019.c
>> +++ b/drivers/net/mdio/mdio-ipq4019.c
> 
> ...
> 
>> +const char *const mdio_clk_name[] = {
>> +	"gcc_mdio_ahb_clk",
>> +	"gcc_uniphy0_ahb_clk",
>> +	"gcc_uniphy0_sys_clk",
>> +	"gcc_uniphy1_ahb_clk",
>> +	"gcc_uniphy1_sys_clk"
>>   };
> 
> Hi Luo Jie,
> 
> A minor nit from my side: It appears that mdio_clk_name is only
> used in this file. If so it should be declared as static.
> 
> ...

Hi Simon,
The mdio_clk_name is only used in this file, will update to use
static, thanks.