linux-kernel - Re: [PATCH] mtd: spi-nor: stop printing superfluous debug info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42c96d63d1ea4f7e8f16a3c8eb0a4cf1@walle.cc>
Date:   Tue, 28 Nov 2023 09:47:28 +0100
From:   Michael Walle <michael@...le.cc>
To:     Tudor Ambarus <tudor.ambarus@...aro.org>
Cc:     miquel.raynal@...tlin.com, jaimeliao.tw@...il.com,
        jaimeliao@...c.com.tw, pratyush@...nel.org, richard@....at,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: stop printing superfluous debug info

Hi,

> The mtd data can be obtain with the mtd ioctls and the SPI NOR
> flash name can be determined interrogating the sysfs entries.
> Stop polluting the kernel log.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> 
> ---
>  drivers/mtd/spi-nor/core.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 25a64c65717d..6de76fd009d1 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3517,25 +3517,6 @@ int spi_nor_scan(struct spi_nor *nor, const char 
> *name,
>  	/* No mtd_info fields should be used up to this point. */
>  	spi_nor_set_mtd_info(nor);
> 
> -	dev_info(dev, "%s (%lld Kbytes)\n", info->name,
> -			(long long)mtd->size >> 10);

I'd lower this to dev_dbg() and print the jedec id. It might come in
handy for a quick glance during bootup if debug is enabled.

> -
> -	dev_dbg(dev,
> -		"mtd .name = %s, .size = 0x%llx (%lldMiB), "
> -		".erasesize = 0x%.8x (%uKiB) .numeraseregions = %d\n",
> -		mtd->name, (long long)mtd->size, (long long)(mtd->size >> 20),
> -		mtd->erasesize, mtd->erasesize / 1024, mtd->numeraseregions);
> -
> -	if (mtd->numeraseregions)
> -		for (i = 0; i < mtd->numeraseregions; i++)
> -			dev_dbg(dev,
> -				"mtd.eraseregions[%d] = { .offset = 0x%llx, "
> -				".erasesize = 0x%.8x (%uKiB), "
> -				".numblocks = %d }\n",
> -				i, (long long)mtd->eraseregions[i].offset,
> -				mtd->eraseregions[i].erasesize,
> -				mtd->eraseregions[i].erasesize / 1024,
> -				mtd->eraseregions[i].numblocks);
>  	return 0;

Part of this is already available through the spi-nor debugfs, although 
not
the actual mtd properties. These I think, should go into the mtdcore
itself if really needed. Either through dev_dbg() or debugfs.

-michael