linux-kernel - Re: [PATCH v3] rootfs: Fix support for rootfstype= when root= is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023112826-cesspool-cabbie-06c5@gregkh>
Date:   Tue, 28 Nov 2023 09:54:01 +0000
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Stefan Berger <stefanb@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, zohar@...ux.ibm.com,
        initramfs@...r.kernel.org, stable@...r.kernel.org,
        Rob Landley <rob@...dley.net>
Subject: Re: [PATCH v3] rootfs: Fix support for rootfstype= when root= is
 given

On Sun, Nov 19, 2023 at 08:12:48PM -0500, Stefan Berger wrote:
> Documentation/filesystems/ramfs-rootfs-initramfs.rst states:
> 
>   If CONFIG_TMPFS is enabled, rootfs will use tmpfs instead of ramfs by
>   default.  To force ramfs, add "rootfstype=ramfs" to the kernel command
>   line.
> 
> This currently does not work when root= is provided since then
> saved_root_name contains a string and rootfstype= is ignored. Therefore,
> ramfs is currently always chosen when root= is provided.
> 
> The current behavior for rootfs's filesystem is:
> 
>    root=       | rootfstype= | chosen rootfs filesystem
>    ------------+-------------+--------------------------
>    unspecified | unspecified | tmpfs
>    unspecified | tmpfs       | tmpfs
>    unspecified | ramfs       | ramfs
>     provided   | ignored     | ramfs
> 
> rootfstype= should be respected regardless whether root= is given,
> as shown below:
> 
>    root=       | rootfstype= | chosen rootfs filesystem
>    ------------+-------------+--------------------------
>    unspecified | unspecified | tmpfs  (as before)
>    unspecified | tmpfs       | tmpfs  (as before)
>    unspecified | ramfs       | ramfs  (as before)
>     provided   | unspecified | ramfs  (compatibility with before)
>     provided   | tmpfs       | tmpfs  (new)
>     provided   | ramfs       | ramfs  (new)
> 
> This table represents the new behavior.
> 
> Fixes: 6e19eded3684 ("initmpfs: use initramfs if rootfstype= or root=  specified")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Rob Landley <rob@...dley.net>
> Link: https://lore.kernel.org/lkml/8244c75f-445e-b15b-9dbf-266e7ca666e2@landley.net/
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Who should take this patch?  Me?  Or someone else?

thanks,

greg k-h