[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6d7527bf-8c1a-49b5-a0cf-99a92098c971@quicinc.com>
Date: Tue, 28 Nov 2023 17:02:06 +0530
From: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To: Johan Hovold <johan@...nel.org>
CC: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, <quic_wcheng@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<quic_ppratap@...cinc.com>, <quic_jackp@...cinc.com>
Subject: Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in
bindings
>
> So back to my initial proposal, with a slight modification moving
> pwr_event first (e.g. as it is not a wakeup interrupt):
>
> qusb2-:
>
> - const: pwr_event
> - const: qusb2_phy
> - const: ss_phy_irq (optional)
>
> qusb2:
>
> - const: pwr_event
> - const: hs_phy_irq
> - const: qusb2_phy
> - const: ss_phy_irq (optional)
>
> femto-:
> - const: pwr_event
> - const: dp_hs_phy_irq
> - const: dm_hs_phy_irq
> - const: ss_phy_irq (optional)
>
> femto:
> - const: pwr_event
> - const: hs_phy_irq
> - const: dp_hs_phy_irq
> - const: dm_hs_phy_irq
> - const: ss_phy_irq (optional)
>
> That ss_phy_irq is optional would be expressed as minItems being one
> less than maxItems for each permutation.
I am fine with this except that "femto-" might not be required. I looked
at
https://lore.kernel.org/all/20231122191436.3146-1-quic_kriskura@quicinc.com/
and I see that all of them have hs_phy_irq.
Regards,
Krishna,
Powered by blists - more mailing lists