linux-kernel - Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8a28c72-5c0a-4a67-a4c9-e46a5716cda4@linaro.org>
Date:   Wed, 29 Nov 2023 10:28:25 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>,
        Johan Hovold <johan@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, quic_wcheng@...cinc.com,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_ppratap@...cinc.com, quic_jackp@...cinc.com
Subject: Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in
 bindings

On 28/11/2023 12:32, Krishna Kurapati PSSNV wrote:
> 
>>
>> So back to my initial proposal, with a slight modification moving
>> pwr_event first (e.g. as it is not a wakeup interrupt):
>>
>> qusb2-:
>>
>> 	- const: pwr_event
>> 	- const: qusb2_phy
>> 	- const: ss_phy_irq	(optional)
>>
>> qusb2:
>>
>> 	- const: pwr_event
>> 	- const: hs_phy_irq
>> 	- const: qusb2_phy
>> 	- const: ss_phy_irq	(optional)
>>
>> femto-:
>> 	- const: pwr_event
>> 	- const: dp_hs_phy_irq
>> 	- const: dm_hs_phy_irq
>> 	- const: ss_phy_irq	(optional)
>>
>> femto:
>> 	- const: pwr_event
>> 	- const: hs_phy_irq
>> 	- const: dp_hs_phy_irq
>> 	- const: dm_hs_phy_irq
>> 	- const: ss_phy_irq	(optional)

I did not follow entire thread and I do not know whether you change the
order in existing bindings, but just in case: the entries in existing
bindings cannot change the order. That's a strict ABI requirement
recently also discussed with Bjorn, because we want to have stable DTB
for laptop platforms. If my comment is not relevant, then please ignore.

Best regards,
Krzysztof