[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <27380394-093e-4b8e-94f8-a1eefc72a020@linaro.org>
Date: Wed, 29 Nov 2023 23:05:26 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Andy Gross <agross@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 02/15] clk: qcom: Use qcom_branch_set_clk_en()
On 29.11.2023 21:59, Bryan O'Donoghue wrote:
> On 29/11/2023 18:59, Konrad Dybcio wrote:
>> Instead of magically poking at the bit0 of branch clocks' CBCR, use
>> the newly introduced helper.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>
>> - /*
>> - * Keep clocks always enabled:
>> - * cam_cc_gdsc_clk
>> - * cam_cc_sleep_clk
>> - */
>> - regmap_update_bits(regmap, 0x1419c, BIT(0), BIT(0));
>> - regmap_update_bits(regmap, 0x142cc, BIT(0), BIT(0));
>> + qcom_branch_set_clk_en(regmap, 0x1419c); /* CAM_CC_GDSC_CLK */
>> + qcom_branch_set_clk_en(regmap, 0x142cc); /* CAM_CC_SLEEP_CLK */
>
> This all looks functionally correct to me, wondering what your motivation for changing the comment is though.
Perhaps I could have included this in the commit message, but:
- it makes sure ARRAY_SIZE(clocks_in_comment) == ARRAY_SIZE(clocks)
- gets rid of different capitalization and wording between files
that triggers my OCD
- also makes it easier to see which register corresponds to which
clock, which is especially helpful if you wanna validate the
guy before you
Konrad
Powered by blists - more mailing lists