linux-kernel - Re: [PATCH 2/2] mei: Add MEI hardware support for IVSC device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <954c8f3f-8093-42bb-b817-c9050d27ca3f@kernel.org>
Date:   Wed, 29 Nov 2023 13:28:20 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Wentong Wu <wentong.wu@...el.com>, gregkh@...uxfoundation.org,
        tomas.winkler@...el.com, hdegoede@...hat.com
Cc:     andriy.shevchenko@...ux.intel.com, sakari.ailus@...ux.intel.com,
        alexander.usyskin@...el.com, zhifeng.wang@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mei: Add MEI hardware support for IVSC device

On 28/11/2023 13:34, Wentong Wu wrote:
> The protocol used for the IVSC device to communicate with HOST is MEI.
> The MEI hardware interfaces for the IVSC device are implemented.
> 

...

> +static DEFINE_SIMPLE_DEV_PM_OPS(mei_vsc_pm_ops, mei_vsc_suspend, mei_vsc_resume);
> +
> +static struct platform_driver mei_vsc_drv = {
> +	.probe = mei_vsc_probe,
> +	.remove = mei_vsc_remove,
> +	.driver = {
> +		.name = "intel_vsc",
> +		.pm = &mei_vsc_pm_ops,
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> +	},
> +};
> +module_platform_driver(mei_vsc_drv);
> +
> +MODULE_AUTHOR("Wentong Wu <wentong.wu@...el.com>");
> +MODULE_AUTHOR("Zhifeng Wang <zhifeng.wang@...el.com>");
> +MODULE_DESCRIPTION("Intel Visual Sensing Controller Interface");
> +MODULE_ALIAS("platform:intel_vsc");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.


Best regards,
Krzysztof