linux-kernel - RE: [PATCH 2/2] mei: Add MEI hardware support for IVSC device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4316ADCA488BE6C5BF85B8618D83A@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Wed, 29 Nov 2023 13:56:14 +0000
From:   "Wu, Wentong" <wentong.wu@...el.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Winkler, Tomas" <tomas.winkler@...el.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "Wang, Zhifeng" <zhifeng.wang@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] mei: Add MEI hardware support for IVSC device

> From: Krzysztof Kozlowski <krzk@...nel.org>
> On 28/11/2023 13:34, Wentong Wu wrote:
> > The protocol used for the IVSC device to communicate with HOST is MEI.
> > The MEI hardware interfaces for the IVSC device are implemented.
> >
> 
> ...
> 
> > +static DEFINE_SIMPLE_DEV_PM_OPS(mei_vsc_pm_ops, mei_vsc_suspend,
> > +mei_vsc_resume);
> > +
> > +static struct platform_driver mei_vsc_drv = {
> > +	.probe = mei_vsc_probe,
> > +	.remove = mei_vsc_remove,
> > +	.driver = {
> > +		.name = "intel_vsc",
> > +		.pm = &mei_vsc_pm_ops,
> > +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> > +	},
> > +};
> > +module_platform_driver(mei_vsc_drv);
> > +
> > +MODULE_AUTHOR("Wentong Wu <wentong.wu@...el.com>");
> > +MODULE_AUTHOR("Zhifeng Wang <zhifeng.wang@...el.com>");
> > +MODULE_DESCRIPTION("Intel Visual Sensing Controller Interface");
> > +MODULE_ALIAS("platform:intel_vsc");
> 
> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
> means your device ID table is wrong (e.g. misses either entries or
> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete
> ID table.

Agree, I forgot the id table and it will be added in next version, thanks

#define MEI_VSC_DRV_NAME		"intel_vsc"

static const struct platform_device_id mei_vsc_id_table[] = {
	{ MEI_VSC_DRV_NAME },
	{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, mei_vsc_id_table);

static struct platform_driver mei_vsc_drv = {
	.probe = mei_vsc_probe,
	.remove = mei_vsc_remove,
	.id_table = mei_vsc_id_table,
	.driver = {
		.name = MEI_VSC_DRV_NAME,
		.pm = &mei_vsc_pm_ops,
		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
	},
};
module_platform_driver(mei_vsc_drv);

MODULE_AUTHOR("Wentong Wu <wentong.wu@...el.com>");
MODULE_AUTHOR("Zhifeng Wang <zhifeng.wang@...el.com>");
MODULE_DESCRIPTION("Intel Visual Sensing Controller Interface");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(VSC_TP);

BR,
Wentong
> 
> 
> Best regards,
> Krzysztof