| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a0181b9c536a4692bab5eb827af1636c@EXMBX066.cuchost.com>
Date: Wed, 29 Nov 2023 13:15:52 +0000
From: JeeHeng Sia <jeeheng.sia@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"kernel@...il.dk" <kernel@...il.dk>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"krzk@...nel.org" <krzk@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
"palmer@...belt.com" <palmer@...belt.com>,
"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"conor@...nel.org" <conor@...nel.org>,
"anup@...infault.org" <anup@...infault.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"jirislaby@...nel.org" <jirislaby@...nel.org>,
"michal.simek@....com" <michal.simek@....com>,
Michael Zhu <michael.zhu@...rfivetech.com>,
"drew@...gleboard.org" <drew@...gleboard.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Leyfoon Tan <leyfoon.tan@...rfivetech.com>
Subject: RE: [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible
string for StarFive JH8100 UART
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, November 29, 2023 6:53 PM
> To: JeeHeng Sia <jeeheng.sia@...rfivetech.com>; kernel@...il.dk; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> krzk@...nel.org; conor+dt@...nel.org; paul.walmsley@...ive.com; palmer@...belt.com; aou@...s.berkeley.edu;
> daniel.lezcano@...aro.org; tglx@...utronix.de; conor@...nel.org; anup@...infault.org; gregkh@...uxfoundation.org;
> jirislaby@...nel.org; michal.simek@....com; Michael Zhu <michael.zhu@...rfivetech.com>; drew@...gleboard.org
> Cc: devicetree@...r.kernel.org; linux-riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Leyfoon Tan
> <leyfoon.tan@...rfivetech.com>
> Subject: Re: [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible string for StarFive JH8100 UART
>
> On 29/11/2023 11:33, JeeHeng Sia wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Wednesday, November 29, 2023 4:26 PM
> >> To: JeeHeng Sia <jeeheng.sia@...rfivetech.com>; kernel@...il.dk; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> >> krzk@...nel.org; conor+dt@...nel.org; paul.walmsley@...ive.com; palmer@...belt.com; aou@...s.berkeley.edu;
> >> daniel.lezcano@...aro.org; tglx@...utronix.de; conor@...nel.org; anup@...infault.org; gregkh@...uxfoundation.org;
> >> jirislaby@...nel.org; michal.simek@....com; Michael Zhu <michael.zhu@...rfivetech.com>; drew@...gleboard.org
> >> Cc: devicetree@...r.kernel.org; linux-riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Leyfoon Tan
> >> <leyfoon.tan@...rfivetech.com>
> >> Subject: Re: [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible string for StarFive JH8100 UART
> >>
> >> On 29/11/2023 07:00, Sia Jee Heng wrote:
> >>> Add new compatible string for UART in the StarFive JH8100 SoC.
> >>>
> >>> Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> >>> Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> >>
> >> The patch is quite different than v1. Are you sure the review is
> >> applicable? If it was given for v2, where is it?
> > This patch is impacted by the comment suggesting the exclusion of patch 5 in V1. In V2, this patch adds compatible for cdns-uart-
> r1p8, allowing us to continue using the cdns uart.
>
> Please wrap your replies.
I am sorry, but may I know the preferred length of characters?
>
> How does this answer my concern about review tag?
My bad. I should have obtained your consensus before proceeding with the changes
to this patch, especially after dropping patch 5 as requested in version 1.
>
> Do you understand that my comments are inline under the exact line which
> is questioned?
Yes, lesson learned.
>
> >>
> >>> ---
> >>> Documentation/devicetree/bindings/serial/cdns,uart.yaml | 4 ++++
> >>> 1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> >>> index e35ad1109efc..0d05305778f2 100644
> >>> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> >>> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> >>> @@ -20,6 +20,10 @@ properties:
> >>> items:
> >>> - const: xlnx,zynqmp-uart
> >>> - const: cdns,uart-r1p12
> >>> + - description: UART controller for StarFive JH8100 SoC
> >>
> >> This is duplicating compatible, drop.
> > Do you mean drop compatible for starfive,jh8100-uart ?
>
> No, drop description and use directly " - items"
Ok.
>
> >>
> >>> + items:
> >>> + - const: starfive,jh8100-uart
> >>> + - const: cdns,uart-r1p8
> >>
> >> Don't add things to the end of the list, but keep order. I would suggest
> >> to put it at the beginning, so before Xilinx.
> > I'm trying to get what you're asking, but it's a bit confusing for me. So, I thought it might be easier if I just share the code below.
> Please let me know if this addresses your comment?
> > properties:
> > compatible:
> > oneOf:
> > - description: UART controller for StarFive JH8100 SoC
> > items:
> > - const: cdns,uart-r1p8
>
> Order is fixed, thanks. But drop description and bring back specific
> compatible. You must have specific compatibles, always.
Noted.
>
>
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists