[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZWi8X7pQpUm-nIpN@smile.fi.intel.com>
Date: Thu, 30 Nov 2023 18:46:23 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 10/10] gpiolib: remove gpiochip_is_requested()
On Thu, Nov 30, 2023 at 02:46:30PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> We have no external users of gpiochip_is_requested(). Let's remove it
> and replace its internal calls with direct testing of the REQUESTED flag.
...
> - cpy = kstrdup(label, GFP_KERNEL);
> - if (!cpy)
> - return ERR_PTR(-ENOMEM);
> + scoped_guard(spinlock_irqsave, &gpio_lock) {
> + if (!test_bit(FLAG_REQUESTED, &desc->flags))
> + return NULL;
> + cpy = kstrdup(desc->label, GFP_KERNEL);
> + if (!cpy)
> + return ERR_PTR(-ENOMEM);
You just introduced these lines earlier in the series, and here you moved
them again. With guard() instead it may be kept in a better shape.
> + }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists