linux-kernel - Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=VGJDcK=tVkOFCnTumxDNE9YfiyAVocmD534mnAd_1CA@mail.gmail.com>
Date:   Thu, 30 Nov 2023 19:55:27 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Paul Burton <paulburton@...nel.org>,
        Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match_data()

On Wed, Nov 15, 2023 at 10:02 PM Rob Herring <robh@...nel.org> wrote:
>
> +       cfg = device_get_match_data(&pdev->dev);

This sounds good to me, but a couple notes:

  - This could be `dev` since we have it, no?

  - Orthogonally, should we just directly initialize `cfg` since now we can?

Cc'ing Geert as well since he was the last one touching the file (in
fact, he added the `dev` variable).

Cheers,
Miguel