linux-kernel - Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXd4ai5bDN4OktKDA_zS6+viDT=x2yFG=_ZbVpfLvGGgA@mail.gmail.com>
Date:   Thu, 30 Nov 2023 20:11:27 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Rob Herring <robh@...nel.org>, Paul Burton <paulburton@...nel.org>,
        Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match_data()

Hi Miguel,

On Thu, Nov 30, 2023 at 7:55 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> On Wed, Nov 15, 2023 at 10:02 PM Rob Herring <robh@...nel.org> wrote:
> > +       cfg = device_get_match_data(&pdev->dev);
>
> This sounds good to me, but a couple notes:
>
>   - This could be `dev` since we have it, no?

Indeed.

>   - Orthogonally, should we just directly initialize `cfg` since now we can?

Yes we can, it would still fit on an 80-column punched card ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds