linux-kernel - [RESEND v2] ACPI: APEI: Skip initialization of GHES_ASSIST structures for Machine Check Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b58c799c-8d3f-4fd8-9ddb-ebb06ef005d5@amd.com>
Date:   Thu, 30 Nov 2023 14:31:02 -0600
From:   Avadhut Naik <avadnaik@....com>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yazen.ghannam@....com" <yazen.ghannam@....com>,
        Avadhut Naik <avadhut.naik@....com>
Subject: [RESEND v2] ACPI: APEI: Skip initialization of GHES_ASSIST structures
 for Machine Check Architecture

Hi,

On 11/30/2023 14:03, Luck, Tony wrote:
>> Actually, caching of values from an earlier structure to be compared against values
>> in a later structure is what we intend to do here i.e. comparing cached source_id
>> from an earlier structure with related_source_id in a later structure. To hint
>> towards the same, I had added the below comment on top of the static structure's
>> declaration:
>>
>>>>> + * Since GHES_ASSIST is not supported, skip initialization
>>>>> + * of GHES_ASSIST structures for MCA.
>>>>> + * During HEST parsing, detected MCA error sources are cached.
>>>>> + * Flags and Source Id fields from these cached values are
>>>>> + * then referred to determine if the encountered GHES_ASSIST
>>>>> + * structure should be initialized.
>>>>> + */
>>
>> Is this not good enough? Should I make it more explicit?
> 
> I understand now, but missed that the caching and use are across
> different entries in the HEST table.
> 
> Maybe something like this:
> 
>  * Since GHES_ASSIST is not supported, skip initialization of GHES_ASSIST
>  * structures for MCA.  During HEST parsing, detected MCA error sources
>  * are cached from early table entries so that Flags and Source Id
>  * fields from these cached values are then referred to in later table
>  * entries to determine if the encountered GHES_ASSIST structure should
>  * be initialized.
> 
Sounds good! Thank you for this. Will update accordingly and resubmit.

> -Tony

-- 
Thanks,
Avadhut Naik