linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0be610ed-ac95-4de1-9639-d634cf979359@linaro.org>
Date:   Thu, 30 Nov 2023 09:06:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock

On 29/11/2023 15:35, Konrad Dybcio wrote:
> On 29.11.2023 15:05, Krzysztof Kozlowski wrote:
>> The TX Soundwire controller should take clock from TX macro codec, not
>> VA macro codec clock, otherwise the clock stays disabled.  This looks
>> like a copy-paste issue, because the SC8280xp code uses here correctly
>> clock from TX macro.  The VA macro clock is already consumed by TX macro
>> codec, thus it won't be disabled by this change.
>>
>> Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers")
>> Reported-by: Neil Armstrong <neil.armstrong@...aro.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> Interestingly, downstream 8550 has
> 
> qcom,use-clk-id = <VA_CORE_CLK>;
> 
> which doesn't seem to be used in techpack

In which node? I see it in the va-macro node, not the tx-macro.

Best regards,
Krzysztof