linux-kernel - RE: [PATCH net v3 4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edd2602be9f24c0c9ee041fdca5a1d3a@realtek.com>
Date:   Thu, 30 Nov 2023 08:27:00 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Douglas Anderson <dianders@...omium.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Grant Grundler <grundler@...omium.org>,
        Laura Nao <laura.nao@...labora.com>,
        Edward Hill <ecgh@...omium.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Simon Horman <horms@...nel.org>,
        Bjørn Mork <bjorn@...k.no>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "Prashant Malani" <pmalani@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net v3 4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1()

Douglas Anderson <dianders@...omium.org>
> Sent: Thursday, November 30, 2023 5:25 AM
[...]
> 
> Delay loops in r8152 should break out if RTL8152_INACCESSIBLE is set
> so that they don't delay too long if the device becomes
> inaccessible. Add the break to the loop in r8153_pre_firmware_1().
> 
> Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153")
> Reviewed-by: Grant Grundler <grundler@...omium.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Acked-by: Hayes Wang <hayeswang@...ltek.com>

Best Regards,
Hayes