linux-kernel - Re: [PATCH net v3 1/5] r8152: Hold the rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170169302472.7913.15839516677330615990.git-patchwork-notify@kernel.org>
Date:   Mon, 04 Dec 2023 12:30:24 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Doug Anderson <dianders@...omium.org>
Cc:     kuba@...nel.org, hayeswang@...ltek.com, davem@...emloft.net,
        linux-usb@...r.kernel.org, grundler@...omium.org,
        laura.nao@...labora.com, ecgh@...omium.org,
        stern@...land.harvard.edu, horms@...nel.org, bjorn@...k.no,
        edumazet@...gle.com, pabeni@...hat.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net v3 1/5] r8152: Hold the rtnl_lock for all of reset

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Wed, 29 Nov 2023 13:25:20 -0800 you wrote:
> As of commit d9962b0d4202 ("r8152: Block future register access if
> register access fails") there is a race condition that can happen
> between the USB device reset thread and napi_enable() (not) getting
> called during rtl8152_open(). Specifically:
> * While rtl8152_open() is running we get a register access error
>   that's _not_ -ENODEV and queue up a USB reset.
> * rtl8152_open() exits before calling napi_enable() due to any reason
>   (including usb_submit_urb() returning an error).
> 
> [...]

Here is the summary with links:
  - [net,v3,1/5] r8152: Hold the rtnl_lock for all of reset
    https://git.kernel.org/netdev/net/c/e62adaeecdc6
  - [net,v3,2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops
    https://git.kernel.org/netdev/net/c/32a574c7e268
  - [net,v3,3/5] r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash()
    https://git.kernel.org/netdev/net/c/8a67b47fced9
  - [net,v3,4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1()
    https://git.kernel.org/netdev/net/c/8c53a7bd7065
  - [net,v3,5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en()
    https://git.kernel.org/netdev/net/c/79321a793945

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html