linux-kernel - Re: [PATCH] tty: max310x: work around regmap->regcache data corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6986fb70-bc99-4210-a622-16f0d0303d27@sirena.org.uk>
Date:   Fri, 1 Dec 2023 16:23:06 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jan Kundrát <jan.kundrat@...net.cz>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: max310x: work around regmap->regcache data
 corruption

On Fri, Dec 01, 2023 at 06:14:02PM +0200, Andy Shevchenko wrote:

> > +       };
> > +       spi_sync_transfer(to_spi_device(port->dev), xfer, ARRAY_SIZE(xfer));

> Can you add a comment like FIXME explaining why regmap is not used
> here, otherwise I will expect some clever guy to "fix" this again.

Or just do the fix in the right place rather than throwing a bodge
about...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)