linux-kernel - Re: [PATCH v2 net-next] packet: add a generic drop reason for receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO3-PbqD5Fpf9ddYFt4OvaT-4fq505X9LfBK0oKareJB+z65gw@mail.gmail.com>
Date:   Fri, 1 Dec 2023 12:30:27 -0600
From:   Yan Zhai <yan@...udflare.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        linux-kernel@...r.kernel.org, kernel-team@...udflare.com,
        Jesper Brouer <jesper@...udflare.com>
Subject: Re: [PATCH v2 net-next] packet: add a generic drop reason for receive

On Fri, Dec 1, 2023 at 12:19 PM Yan Zhai <yan@...udflare.com> wrote:
>
> On Fri, Dec 1, 2023 at 11:51 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > >         bool is_drop_n_account = false;
> >
> > Why keeping is_drop_n_account  then ?
>
> Good catch, thanks! Will send a v3 to fix up.
> Meanwhile, I noticed it is compiled with the
> -Wno-unused-but-set-variable flag, is there a reason why we disable
> this warning?

I found the answer in scripts/Makefile.extrawarn. Good to learn how this works!

>
> Yan