linux-kernel - Re: [PATCH v2] scripts/show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWmB67THrLcztb-3@buildd.core.avm.de>
Date:   Fri, 1 Dec 2023 07:49:13 +0100
From:   Nicolas Schier <n.schier@....de>
To:     Hu Haowen <2023002089@...k.tyut.edu.cn>
Cc:     gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        masahiroy@...nel.org, ndesaulniers@...gle.com, ojeda@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scripts/show_delta: reformat code

On Fri, Dec 01, 2023 at 01:35:40PM +0800, Hu Haowen wrote:
> Correct some lines in irregular coding style to make them look more
> harmonious and fit the common coding regulations in Python.
> 
> Signed-off-by: Hu Haowen <2023002089@...k.tyut.edu.cn>
> ---
>  scripts/show_delta | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 291ad65e3089..33446adce74b 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -13,7 +13,7 @@ import sys
>  import string
>  
>  def usage():
> -	print ("""usage: show_delta [<options>] <filename>
> +	print("""usage: show_delta [<options>] <filename>

Hi,

thanks for your patch.  What Miguel already noticed for v1 is valid for
v2, too: there are still inconsistencies in the coding style, e.g.
`print (...)` and `print(...)`.

To simplify a consistent coding style for future work on the script,
using an external tool for reformatting (and mentioning it in the commit
message) would be helpful.  Miguel suggested Black or Ruff, I think this
is a good idea.

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)