[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZWmHT4CfFdadT1bB@google.com>
Date: Fri, 1 Dec 2023 07:12:15 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Arve Hjønnevåg <arve@...roid.com>,
Christian Brauner <brauner@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Joel Fernandes <joel@...lfernandes.org>,
kernel-team@...roid.com, linux-kernel@...r.kernel.org,
Martijn Coenen <maco@...roid.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Todd Kjos <tkjos@...roid.com>
Subject: Re: [PATCH 13/21] binder: relocate low space calculation
On Tue, Nov 07, 2023 at 09:08:26AM +0000, Alice Ryhl wrote:
> Carlos Llamas <cmllamas@...gle.com> writes:
> > Move the low async space calculation to debug_low_async_space_locked().
> > This logic not only fits better here but also offloads some of the many
> > tasks currently done in binder_alloc_new_buf_locked().
> >
> > No functional change in this patch.
> >
> > Signed-off-by: Carlos Llamas <cmllamas@...gle.com>
>
> One suggestion below, but I'm fine either way.
>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
>
>
> Carlos Llamas <cmllamas@...gle.com> writes:
> > + if (debug_low_async_space_locked(alloc))
> > + buffer->oneway_spam_suspect = true;
>
> You could avoid a branch here like this:
>
Sure, sounds good to me.
--
Carlos Llamas
Powered by blists - more mailing lists