linux-kernel - Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWmn6uicNIqqSwoE@hovoldconsulting.com>
Date:   Fri, 1 Dec 2023 10:31:22 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example

On Fri, Dec 01, 2023 at 09:32:46AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:32, Johan Hovold wrote:
> > The PM8921 is an SSBI PMIC but in the binding example it is described
> > as being part of an SPMI PMIC while using an SSBI address.
> > 
> > Make the example consistent by using the sibling PM8941 SPMI PMIC
> > instead.
> > 
> > Fixes: 8138c5f0318c ("dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings")
> 
> Similarly to your thermal patch - this is just an example, not a
> binding. No bugs are fixed here, no need for backports.

A Fixes tag does not in itself imply that something should be
backported, we have CC-stable tags for that.

And if this was just about the name, I'd agree with you that a Fixes tag
is not warranted either, but the way I see this this is more than that
as the "spmi" name suggests that these "devices" sit directly on the
SPMI bus which would require a different binding entirely.

The naming therefore becomes misleading and should be fixed to assist
any casual consumer of these binding documents.

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks for reviewing these.

Johan