linux-kernel - Re: drivers/input/touchscreen/egalax_ts_serial.c:116:21: warning: '/input0' directive output may be truncated writing 7 bytes into a region of size between 1 and 32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWwe1DJ7gBdOUHwY@google.com>
Date:   Sun, 3 Dec 2023 06:23:16 +0000
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Böszörményi Zoltán <zboszormenyi@...om.com>,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: drivers/input/touchscreen/egalax_ts_serial.c:116:21: warning:
 '/input0' directive output may be truncated writing 7 bytes into a region of
 size between 1 and 32

On Sun, Dec 03, 2023 at 02:07:07PM +0800, kernel test robot wrote:
> Hi Böszörményi,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   815fb87b753055df2d9e50f6cd80eb10235fe3e9
> commit: 6b0f8f9c52efe24d6dac06ab963b7bd91c723751 Input: add eGalaxTouch serial touchscreen driver
> date:   8 years ago
> config: x86_64-randconfig-r032-20230515 (https://download.01.org/0day-ci/archive/20231202/202312021646.cwwvptuB-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231202/202312021646.cwwvptuB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312021646.cwwvptuB-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/kobject.h:21,
>                     from include/linux/module.h:17,
>                     from drivers/input/touchscreen/egalax_ts_serial.c:19:
>    include/linux/sysfs.h: In function 'sysfs_get_dirent':
>    include/linux/sysfs.h:517:44: warning: pointer targets in passing argument 2 of 'kernfs_find_and_get' differ in signedness [-Wpointer-sign]
>      517 |         return kernfs_find_and_get(parent, name);
>          |                                            ^~~~
>          |                                            |
>          |                                            const unsigned char *
>    In file included from include/linux/sysfs.h:15:
>    include/linux/kernfs.h:428:57: note: expected 'const char *' but argument is of type 'const unsigned char *'
>      428 | kernfs_find_and_get(struct kernfs_node *kn, const char *name)
>          |                                             ~~~~~~~~~~~~^~~~
>    drivers/input/touchscreen/egalax_ts_serial.c: In function 'egalax_connect':
> >> drivers/input/touchscreen/egalax_ts_serial.c:116:21: warning: '/input0' directive output may be truncated writing 7 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
>      116 |                  "%s/input0", serio->phys);

Please stop using -Wformat-truncation and report warnings as errors.
This particular warning is disabled in normal builds and the truncation
is desired outcome here.

Thanks.

-- 
Dmitry