| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202312022333.adC50Ho6-lkp@intel.com>
Date: Sun, 3 Dec 2023 14:31:35 +0800
From: kernel test robot <lkp@...el.com>
To: Michal Suchanek <hramrach@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Brian Norris <computersforpeace@...il.com>
Subject: drivers/mtd/mtdpart.c:768:26: warning: '%s' directive argument is
null
Hi Michal,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 815fb87b753055df2d9e50f6cd80eb10235fe3e9
commit: 8e2c992b59fcb5e56e3667f5c30c7d26fbbf14a2 mtd: mtdpart: add debug prints to partition parser.
date: 8 years ago
config: x86_64-randconfig-x001-20230722 (https://download.01.org/0day-ci/archive/20231202/202312022333.adC50Ho6-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231202/202312022333.adC50Ho6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312022333.adC50Ho6-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/kobject.h:21,
from include/linux/module.h:17,
from drivers/mtd/mtdpart.c:24:
include/linux/sysfs.h: In function 'sysfs_get_dirent':
include/linux/sysfs.h:496:44: warning: pointer targets in passing argument 2 of 'kernfs_find_and_get' differ in signedness [-Wpointer-sign]
496 | return kernfs_find_and_get(parent, name);
| ^~~~
| |
| const unsigned char *
In file included from include/linux/sysfs.h:15:
include/linux/kernfs.h:428:57: note: expected 'const char *' but argument is of type 'const unsigned char *'
428 | kernfs_find_and_get(struct kernfs_node *kn, const char *name)
| ~~~~~~~~~~~~^~~~
In file included from include/linux/kernel.h:13,
from include/linux/list.h:8,
from include/linux/module.h:9:
drivers/mtd/mtdpart.c: In function 'parse_mtd_partitions':
>> drivers/mtd/mtdpart.c:768:26: warning: '%s' directive argument is null [-Wformat-overflow=]
768 | pr_debug("%s: got parser %s\n", master->name,
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:236:21: note: in definition of macro 'pr_fmt'
236 | #define pr_fmt(fmt) fmt
| ^~~
include/linux/printk.h:283:9: note: in expansion of macro 'dynamic_pr_debug'
283 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/mtd/mtdpart.c:768:17: note: in expansion of macro 'pr_debug'
768 | pr_debug("%s: got parser %s\n", master->name,
| ^~~~~~~~
drivers/mtd/mtdpart.c:768:42: note: format string is defined here
768 | pr_debug("%s: got parser %s\n", master->name,
| ^~
vim +768 drivers/mtd/mtdpart.c
732
733 /**
734 * parse_mtd_partitions - parse MTD partitions
735 * @master: the master partition (describes whole MTD device)
736 * @types: names of partition parsers to try or %NULL
737 * @pparts: array of partitions found is returned here
738 * @data: MTD partition parser-specific data
739 *
740 * This function tries to find partition on MTD device @master. It uses MTD
741 * partition parsers, specified in @types. However, if @types is %NULL, then
742 * the default list of parsers is used. The default list contains only the
743 * "cmdlinepart" and "ofpart" parsers ATM.
744 * Note: If there are more then one parser in @types, the kernel only takes the
745 * partitions parsed out by the first parser.
746 *
747 * This function may return:
748 * o a negative error code in case of failure
749 * o zero if no partitions were found
750 * o a positive number of found partitions, in which case on exit @pparts will
751 * point to an array containing this number of &struct mtd_info objects.
752 */
753 int parse_mtd_partitions(struct mtd_info *master, const char *const *types,
754 struct mtd_partition **pparts,
755 struct mtd_part_parser_data *data)
756 {
757 struct mtd_part_parser *parser;
758 int ret = 0;
759
760 if (!types)
761 types = default_mtd_part_types;
762
763 for ( ; ret <= 0 && *types; types++) {
764 pr_debug("%s: parsing partitions %s\n", master->name, *types);
765 parser = get_partition_parser(*types);
766 if (!parser && !request_module("%s", *types))
767 parser = get_partition_parser(*types);
> 768 pr_debug("%s: got parser %s\n", master->name,
769 parser ? parser->name : NULL);
770 if (!parser)
771 continue;
772 ret = (*parser->parse_fn)(master, pparts, data);
773 pr_debug("%s: parser %s: %i\n",
774 master->name, parser->name, ret);
775 put_partition_parser(parser);
776 if (ret > 0) {
777 printk(KERN_NOTICE "%d %s partitions found on MTD device %s\n",
778 ret, parser->name, master->name);
779 break;
780 }
781 }
782 return ret;
783 }
784
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists