linux-kernel - RE: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase outstanding LMTST transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR18MB2602CA69A2BD90500C4A9C31CD86A@DM6PR18MB2602.namprd18.prod.outlook.com>
Date:   Mon, 4 Dec 2023 05:28:06 +0000
From:   Geethasowjanya Akula <gakula@...vell.com>
To:     Simon Horman <horms@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Pavan Nikhilesh Bhagavatula <pbhagavatula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: RE: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
 outstanding LMTST transactions



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, December 1, 2023 5:05 PM
> To: Geethasowjanya Akula <gakula@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kuba@...nel.org;
> davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Sunil
> Kovvuri Goutham <sgoutham@...vell.com>; Linu Cherian
> <lcherian@...vell.com>; Jerin Jacob Kollanukkaran <jerinj@...vell.com>;
> Pavan Nikhilesh Bhagavatula <pbhagavatula@...vell.com>; Subbaraya
> Sundeep Bhatta <sbhatta@...vell.com>; Hariprasad Kelam
> <hkelam@...vell.com>
> Subject: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
> outstanding LMTST transactions
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, Nov 29, 2023 at 04:51:55PM +0530, Geetha sowjanya wrote:
> > From: Pavan Nikhilesh <pbhagavatula@...vell.com>
> >
> > Currently the number of outstanding store transactions issued by AP as
> > a part of LMTST operation is set to 1 i.e default value.
> > This patch set to max supported value to increase the performance.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@...vell.com>
> > Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > index 0e74c5a2231e..93fedabfe31e 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > @@ -559,3 +559,12 @@ void rvu_nix_block_cn10k_init(struct rvu *rvu,
> struct nix_hw *nix_hw)
> >  	cfg |= BIT_ULL(1) | BIT_ULL(2);
> >  	rvu_write64(rvu, blkaddr, NIX_AF_CFG, cfg);  }
> > +
> > +void rvu_apr_block_cn10k_init(struct rvu *rvu) {
> > +	u64 reg;
> > +
> > +	reg = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_CFG);
> > +	reg |= 0xFULL << 35;
> 
> Hi Pavan and Geetha,
> 
> I think it would be best to avoid the magic value 35 here.
> 
> Best would probably be to use GENMASK_ULL and FIELD_PREP.
> Else defining something similar to APR_LMT_MAP_ENT_SCH_ENA_SHIFT.
> 
> It might also be nice to avoid the magic value 0xFULL using a #define.
Ack. Will submit next version.
> 
> > +	rvu_write64(rvu, BLKADDR_APR, APR_AF_LMT_CFG, reg); }
> > --
> > 2.25.1
> >