linux-kernel - Re: [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b65f67a-8142-4690-af6e-4a0bf641b7be@kernel.org>
Date:   Mon, 4 Dec 2023 08:56:58 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Tengfei Fan <quic_tengfan@...cinc.com>, andersson@...nel.org,
        agross@...nel.org, konrad.dybcio@...aro.org,
        linus.walleij@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver

On 04/12/2023 02:57, Tengfei Fan wrote:
> 
> 
> 在 11/30/2023 7:57 PM, Krzysztof Kozlowski 写道:
>> On 30/11/2023 03:40, Tengfei Fan wrote:
>>> Add pinctrl driver for TLMM block found in SM4450 SoC.
>>>
>>> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>> ---
>>>   drivers/pinctrl/qcom/Kconfig.msm      |    8 +
>>>   drivers/pinctrl/qcom/Makefile         |    1 +
>>>   drivers/pinctrl/qcom/pinctrl-sm4450.c | 1013 +++++++++++++++++++++++++
>>>   3 files changed, 1022 insertions(+)
>>>   create mode 100644 drivers/pinctrl/qcom/pinctrl-sm4450.c
>>>
>>
>> Hm, was this patch ever built?
>>
>> Best regards,
>> Krzysztof
>>
> This patch has been built before, I will check and compare if there are 
> any errors and changes when I submitted this patch series.
> 

No, it wasn't built. I just tried - applied it and:

pinctrl-sm4450.c:996:19: error: initialization of ‘int (*)(struct
platform_device *)’ from incompatible pointer type ‘void (*)(struct
platform_device *)’ [-Werror=incompatible-pointer-types]
  996 |         .remove = msm_pinctrl_remove,
      |                   ^~~~~~~~~~~~~~~~~~
../drivers/pinctrl/qcom/pinctrl-sm4450.c:996:19: note: (near
initialization for ‘sm4450_tlmm_driver.remove’)

So you just sent a patch which was not even compiled.

NAK.

Best regards,
Krzysztof