linux-kernel - Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ca586ea-ba5b-4574-a93c-d92d930214b1@amd.com>
Date:   Mon, 4 Dec 2023 08:57:15 +0100
From:   Michal Simek <michal.simek@....com>
To:     Conor Dooley <conor@...nel.org>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        michal.simek@...inx.com, git@...inx.com,
        Conor Dooley <conor+dt@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels



On 12/1/23 17:07, Conor Dooley wrote:
> On Fri, Dec 01, 2023 at 09:35:27AM +0100, Michal Simek wrote:
>>
>>
>> On 11/30/23 15:58, Conor Dooley wrote:
>>> On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote:
>>>> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels
>>>> that's why increase it.
>>>> But AMS binding defines 51 channels
>>>> Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
>>>> that's why increase number to 51.
>>>
>>> Please write commit messages for bindings in terms of how they relate to
>>> some hardware. In this case I think it would be sufficient to say that
>>> the Analog Monitoring system has 51 channels, the opening sentence about
>>> the dts as justification provides no actionable information.
>>> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
>>
>> v2 sent.
> 
> I wasn't requesting a v2 FWIW. "$file uses 30 channels" rather than
> rephrasing it in terms of the hardware actually having 51 channels just
> annoyed me, that's all.

I know and I agreed that commit message can be improved that's why sent v2.

Thanks,
Michal