linux-kernel - [PATCH v2 27/28] binder: reverse locking order in shrinker callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204115743.43597-1-aliceryhl@google.com>
Date:   Mon,  4 Dec 2023 11:57:42 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     cmllamas@...gle.com
Cc:     arve@...roid.com, brauner@...nel.org, gregkh@...uxfoundation.org,
        joel@...lfernandes.org, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org, maco@...roid.com, surenb@...gle.com,
        tkjos@...roid.com
Subject: [PATCH v2 27/28] binder: reverse locking order in shrinker callback

> +	trace_binder_unmap_kernel_start(alloc, index);
> +
> +	page_to_free = page->page_ptr;
> +	page->page_ptr = NULL;
> +
> +	trace_binder_unmap_kernel_end(alloc, index);

What are these trace calls used for? Previously they wrapped the call to
__free_page, and happened after the `trace_binder_unmap_user_*` calls.

I'm guessing they should be moved down to wrap the call to __free_page.

Alice