linux-kernel - Re: [PATCH 1/2] drm/imagination: Removed unused functions in pvr_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8a7c276a8c7c9713d21aaeb3c4bb45fbfa43af8.camel@imgtec.com>
Date:   Mon, 4 Dec 2023 13:51:08 +0000
From:   Donald Robson <Donald.Robson@...tec.com>
To:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "lkp@...el.com" <lkp@...el.com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        Matt Coster <Matt.Coster@...tec.com>,
        "airlied@...il.com" <airlied@...il.com>,
        Frank Binns <Frank.Binns@...tec.com>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "mripard@...nel.org" <mripard@...nel.org>
Subject: Re: [PATCH 1/2] drm/imagination: Removed unused functions in
 pvr_fw_trace

Just to clarify, there is no [PATCH 2/2].  I made the patch from the wrong branch
and didn't notice format-patch had picked up another commit.

Thanks,
Donald

On Mon, 2023-12-04 at 13:36 +0000, Donald Robson wrote:
> *** NOTE: This is an internal email from Imagination Technologies ***
> 
> 
> 
> 
> Fixing the warning below due to an unused file level vtable. Removing
> only this causes additional warnings for the now unused functions, so
> I've removed those too.
> 
> > > drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
>      205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/
> Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")
> Signed-off-by: Donald Robson <donald.robson@...tec.com>
> ---
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 44 ----------------------
>  1 file changed, 44 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> index 87a42fb6ace6..30f41a10a0cf 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> @@ -167,50 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
> 
>  #if defined(CONFIG_DEBUG_FS)
> 
> -static int fw_trace_group_mask_show(struct seq_file *m, void *data)
> -{
> -       struct pvr_device *pvr_dev = m->private;
> -
> -       seq_printf(m, "%08x\n", pvr_dev->fw_dev.fw_trace.group_mask);
> -
> -       return 0;
> -}
> -
> -static int fw_trace_group_mask_open(struct inode *inode, struct file *file)
> -{
> -       return single_open(file, fw_trace_group_mask_show, inode->i_private);
> -}
> -
> -static ssize_t fw_trace_group_mask_write(struct file *file, const char __user *ubuf, size_t len,
> -                                        loff_t *offp)
> -{
> -       struct seq_file *m = file->private_data;
> -       struct pvr_device *pvr_dev = m->private;
> -       u32 new_group_mask;
> -       int err;
> -
> -       err = kstrtouint_from_user(ubuf, len, 0, &new_group_mask);
> -       if (err)
> -               return err;
> -
> -       err = update_logtype(pvr_dev, new_group_mask);
> -       if (err)
> -               return err;
> -
> -       pvr_dev->fw_dev.fw_trace.group_mask = new_group_mask;
> -
> -       return (ssize_t)len;
> -}
> -
> -static const struct file_operations pvr_fw_trace_group_mask_fops = {
> -       .owner = THIS_MODULE,
> -       .open = fw_trace_group_mask_open,
> -       .read = seq_read,
> -       .write = fw_trace_group_mask_write,
> -       .llseek = default_llseek,
> -       .release = single_release,
> -};
> -
>  struct pvr_fw_trace_seq_data {
>         /** @buffer: Pointer to copy of trace data. */
>         u32 *buffer;
> --
> 2.25.1
>