linux-kernel - Re: [PATCH 1/2] drm/imagination: Removed unused functions in pvr_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7rwnnzsh6mlfnp5nqsxlehtc7siznebppixap7lh56kkr274jo@wtilprrqiuw4>
Date:   Mon, 4 Dec 2023 14:55:39 +0100
From:   Maxime Ripard <mripard@...nel.org>
To:     Donald Robson <donald.robson@...tec.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        frank.binns@...tec.com, matt.coster@...tec.com,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] drm/imagination: Removed unused functions in
 pvr_fw_trace

Hi,

On Mon, Dec 04, 2023 at 01:36:11PM +0000, Donald Robson wrote:
> Fixing the warning below due to an unused file level vtable. Removing
> only this causes additional warnings for the now unused functions, so
> I've removed those too.
> 
> >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
>      205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/
> Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")

That commit doesn't exist (upstream).

You made that mistake on the 5 patches you sent last week too but I
forgot to tell you about it. Are you working from a private branch?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)