linux-kernel - drivers/hid/hid-mcp2221.c:1019:3-4: Unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2023 22:14:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Matt Ranostay <matt.ranostay@...sulko.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Jiri Kosina <jkosina@...e.cz>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: drivers/hid/hid-mcp2221.c:1019:3-4: Unneeded semicolon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: 960f9df7c620ecb6030aff1d9a6c3d67598b8290 HID: mcp2221: add ADC/DAC support via iio subsystem
date:   1 year, 2 months ago
config: i386-randconfig-053-20231204 (https://download.01.org/0day-ci/archive/20231205/202312052224.8IO8gNm0-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231205/202312052224.8IO8gNm0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312052224.8IO8gNm0-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/hid/hid-mcp2221.c:1019:3-4: Unneeded semicolon

vim +1019 drivers/hid/hid-mcp2221.c

   993	
   994	static int mcp_iio_channels(struct mcp2221 *mcp)
   995	{
   996		int idx, cnt = 0;
   997		bool dac_created = false;
   998	
   999		/* GP0 doesn't have ADC/DAC alternative function */
  1000		for (idx = 1; idx < MCP_NGPIO; idx++) {
  1001			struct iio_chan_spec *chan = &mcp->iio_channels[cnt];
  1002	
  1003			switch (mcp->mode[idx]) {
  1004			case 2:
  1005				chan->address = idx - 1;
  1006				chan->channel = cnt++;
  1007				break;
  1008			case 3:
  1009				/* GP1 doesn't have DAC alternative function */
  1010				if (idx == 1 || dac_created)
  1011					continue;
  1012				/* DAC1 and DAC2 outputs are connected to the same DAC */
  1013				dac_created = true;
  1014				chan->output = 1;
  1015				cnt++;
  1016				break;
  1017			default:
  1018				continue;
> 1019			};
  1020	
  1021			chan->type = IIO_VOLTAGE;
  1022			chan->indexed = 1;
  1023			chan->info_mask_separate = BIT(IIO_CHAN_INFO_RAW);
  1024			chan->info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE);
  1025			chan->scan_index = -1;
  1026		}
  1027	
  1028		return cnt;
  1029	}
  1030	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki