linux-kernel - Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msuopv1c.fsf@kernel.org>
Date:   Tue, 05 Dec 2023 16:45:51 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Felix Fietkau <nbd@...nwrt.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna

Jiri Slaby <jirislaby@...nel.org> writes:

> On 05. 12. 23, 13:07, Kalle Valo wrote:
>> "Jiri Slaby (SUSE)" <jirislaby@...nel.org> writes:
>> 
>>> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
>>> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
>>> parsing and add missing calibration data") added it, but did not use it
>>> in any way. Neither, there is a later user.
>>>
>>> So remove that unused member.
>>>
>>> [1] https://github.com/jirislaby/clang-struct
>>
>> clang-struct looks really nice, especially if it can also find unused
>> structures.
>
> It can...

Nice!

>> What about unused defines or enums, any chance to find those
>> in the future? :)
>
> All of that is IMO possible (I'm not completely sure about macros,
> despite clang ASTs provide a lot of info. Incl. info about them and
> their expansion).

Too bad, I wish that there would be a tool for that. I suspect wireless
drivers have unused defines and enums, it would be nice to clean up
that.

> It's all limited only by man-force: me.

Yeah, I guessed that. Thanks for making this tool available, hopefully
more people start using it.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches