linux-kernel - Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dde1fdb0-c905-4c46-baf6-cdc1011df4cc@kernel.org>
Date:   Tue, 5 Dec 2023 14:10:11 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Felix Fietkau <nbd@...nwrt.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna

On 05. 12. 23, 13:07, Kalle Valo wrote:
> "Jiri Slaby (SUSE)" <jirislaby@...nel.org> writes:
> 
>> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
>> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
>> parsing and add missing calibration data") added it, but did not use it
>> in any way. Neither, there is a later user.
>>
>> So remove that unused member.
>>
>> [1] https://github.com/jirislaby/clang-struct
> 
> clang-struct looks really nice, especially if it can also find unused
> structures.

It can...

> What about unused defines or enums, any chance to find those
> in the future? :)

All of that is IMO possible (I'm not completely sure about macros, 
despite clang ASTs provide a lot of info. Incl. info about them and 
their expansion).

It's all limited only by man-force: me.

thanks,
-- 
js
suse labs