linux-kernel - Re: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2023 14:36:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kamel Bouhara <kamel.bouhara@...tlin.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Henrik Rydberg <rydberg@...math.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Marco Felsch <m.felsch@...gutronix.de>,
        Jeff LaBundy <jeff@...undy.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        catalin.popescu@...ca-geosystems.com,
        mark.satterthwaite@...chnetix.com, bartp@...sheep.co.uk,
        hannah.rossiter@...chnetix.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        bsp-development.geo@...ca-geosystems.com,
        Kamel Bouhara <kamel.bouhara@...tlin.com>
Subject: Re: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver

Hi Kamel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus robh/for-next linus/master krzk-dt/for-next v6.7-rc4 next-20231204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kamel-Bouhara/dt-bindings-vendor-prefixes-Add-TouchNetix-AS/20231204-222017
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link:    https://lore.kernel.org/r/20231204140505.2838916-4-kamel.bouhara%40bootlin.com
patch subject: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051457.y3N1q3sZ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051457.y3N1q3sZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051457.y3N1q3sZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/touchscreen/touchnetix_axiom.c: In function 'axiom_usage_to_target_address':
>> drivers/input/touchscreen/touchnetix_axiom.c:142:31: warning: variable 'device_info' set but not used [-Wunused-but-set-variable]
     142 |         struct axiom_devinfo *device_info;
         |                               ^~~~~~~~~~~


vim +/device_info +142 drivers/input/touchscreen/touchnetix_axiom.c

   136	
   137	/* Translate usage/page/offset triplet into physical address. */
   138	static u16 axiom_usage_to_target_address(struct axiom_data *ts, char usage, char page,
   139						 char offset)
   140	{
   141		struct axiom_usage_entry *usage_table;
 > 142		struct axiom_devinfo *device_info;
   143		u32 i;
   144	
   145		device_info = &ts->devinfo;
   146		usage_table = ts->usage_table;
   147	
   148		/* At the moment the convention is that u31 is always at physical address 0x0 */
   149		if (!ts->usage_table_populated) {
   150			if (usage == AXIOM_DEVINFO_USAGE_ID)
   151				return ((page << 8) + offset);
   152			else
   153				return 0xffff;
   154		}
   155	
   156		for (i = 0; i < ts->devinfo.num_usages; i++) {
   157			if (usage_table[i].id != usage)
   158				continue;
   159	
   160			if (page >= usage_table[i].num_pages) {
   161				dev_err(ts->dev, "Invalid usage table! usage: %u, page: %u, offset: %u\n",
   162					usage, page, offset);
   163				return 0xffff;
   164			}
   165			break;
   166		}
   167	
   168		return ((usage_table[i].start_page + page) << 8) + offset;
   169	}
   170	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki