linux-kernel - Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231206174451.301b1cd2@jic23-huawei>
Date:   Wed, 6 Dec 2023 17:44:51 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Petre Rodan <petre.rodan@...dimension.ro>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Andreas Klinger <ak@...klinger.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC
 series

On Mon,  4 Dec 2023 21:43:59 +0200
Petre Rodan <petre.rodan@...dimension.ro> wrote:

> Adds driver for digital Honeywell TruStability HSC and SSC series
> pressure and temperature sensors.
> Communication is one way. The sensor only requires 4 bytes worth of
> clock pulses on both i2c and spi in order to push the data out.
> The i2c address is hardcoded and depends on the part number.
> There is no additional GPIO control.
> 
> Datasheet:
> https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf [HSC]
> Datasheet:
> https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf [SSC]
> Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
One trivial comment from me to add to what Andy covered.

> +/*
/**
Looks to be valid kernel-doc. Might as well mark it as such.


> + * hsc_measurement_is_valid() - validate last conversion via status bits
> + * @data: structure containing instantiated sensor data
> + * Return: true only if both status bits are zero
> + *
> + * the two MSB from the first transfered byte contain a status code
> + *   00 - normal operation, valid data
> + *   01 - device in factory programming mode
> + *   10 - stale data
> + *   11 - diagnostic condition
> + */