linux-kernel - Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231206174558.27f72d37@jic23-huawei>
Date:   Wed, 6 Dec 2023 17:45:58 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Petre Rodan <petre.rodan@...dimension.ro>,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Andreas Klinger <ak@...klinger.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC
 series


> > +		ret = match_string(hsc_triplet_variants, HSC_VARIANTS_MAX,
> > +						triplet);
> > +		if (ret < 0)
> > +			return dev_err_probe(dev, -EINVAL,
> > +				"honeywell,pressure-triplet is invalid\n");  
> 
> Still you can use mentioned device property API.
> 

This is one of the rare cases where basing on iio/togreg is
sensible because you do want a feature that only exists there today.
Just state that you have done so in the cover letter.

Jonathan


> ...
> 
> > +		return dev_err_probe(dev, -EINVAL,
> > +			"pressure limits are invalid\n");  
> 
> Indentation?
>